Fix. Upload checker. Check ability to run the checker.#665
Merged
Glomberg merged 11 commits intoJun 8, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Upload Checker execution flow to (1) add upload rate limiting and (2) gate running the checker behind additional permission/nonce checks in the admin upload flows.
Changes:
- Added a dedicated rate-limiter hook for Upload Checker requests (
UploadChecker::hasRateOverlimit()). - Updated
spbc_upload_checker__check()to validate user capability/nonce (where applicable) and to block on rate-limit exceed. - Switched archive/content checking calls to instance-method invocation (
$this->...) insideUploadChecker.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
lib/CleantalkSP/SpbctWP/Firewall/UploadChecker.php |
Introduces Upload Checker rate limiting helper and fixes non-static method calls to use $this. |
inc/spbc-firewall.php |
Adds preflight permission/nonce checks and applies Upload Checker rate limiting before running the module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ck-ability-to-run-the-checker-VI
AntonV1211
approved these changes
Jun 5, 2026
svfcode
approved these changes
Jun 6, 2026
Glomberg
deleted the
Fix-Upload-checker-Check-ability-to-run-the-checker-VI
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/49977